[SDK] Improve ERC1155 test coverage #4985

kien-ngo · 2024-10-10T09:54:53Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing test cases for various ERC20 and ERC1155 functionalities by conditionally running tests based on the presence of a TW_SECRET_KEY. It also introduces new tests for lazy minting and additional supply minting capabilities.

Detailed summary

Updated describe blocks to conditionally run tests using describe.runIf(process.env.TW_SECRET_KEY).
Added tests for isLazyMintSupported in erc1155: lazyMint.
Added tests for isMintAdditionalSupplyToSupported in erc1155: mintAdditionalSupplyTo.
Added tests for minting functionality in erc1155: mintTo.
Added tests for isGetNFTsSupported in ERC1155 getNFTs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-10T09:54:56Z

⚠️ No Changeset found

Latest commit: 50e359d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-10T09:54:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:42pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:42pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:42pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 11:42pm

graphite-app · 2024-10-10T09:54:59Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

github-actions · 2024-10-10T09:58:39Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.07 KB (0%)	842 ms (0%)	2.3 s (+25.68% 🔺)	3.2 s
thirdweb (cjs)	101.87 KB (0%)	2.1 s (0%)	5 s (+10.42% 🔺)	7 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	235 ms (-23.06% 🔽)	332 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	66 ms (+2.9% 🔺)	76 ms
thirdweb/react (minimal + tree-shaking)	17.24 KB (0%)	345 ms (0%)	367 ms (-42.94% 🔽)	712 ms

codecov · 2024-10-10T10:02:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (a1a6574) to head (50e359d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4985      +/-   ##
==========================================
+ Coverage   47.71%   47.77%   +0.05%     
==========================================
  Files        1059     1058       -1     
  Lines       57314    57276      -38     
  Branches     3944     3947       +3     
==========================================
+ Hits        27350    27362      +12     
+ Misses      29273    29223      -50     
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from a1a6574
packages	`43.57% <ø> (+0.06%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 8 files with indirect coverage changes

graphite-app · 2024-10-13T23:30:10Z

Merge activity

Oct 13, 7:30 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 13, 7:40 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing test coverage for the ERC20 and ERC1155 extensions in the `thirdweb` package. It introduces conditional test execution based on the presence of a secret key and adds new tests to verify specific functionalities. ### Detailed summary - Updated `describe` blocks to conditionally run tests based on `process.env.TW_SECRET_KEY` for multiple test files. - Added tests for `isLazyMintSupported` in `erc1155: lazyMint`. - Added tests for `isMintAdditionalSupplyToSupported` in `erc1155: mintAdditionalSupplyTo`. - Added tests for `mintTo` functionality in `erc1155: mintTo`. - Added tests for `isGetNFTsSupported` in `ERC1155 getNFTs`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo requested review from gregfromstl, jnsdls and joaquim-verges as code owners October 10, 2024 09:54

kien-ngo self-assigned this Oct 10, 2024

github-actions bot added the packages label Oct 10, 2024

vercel bot deployed to Preview – wallet-ui October 10, 2024 09:56 View deployment

vercel bot deployed to Preview – thirdweb_playground October 10, 2024 09:57 View deployment

vercel bot deployed to Preview – thirdweb-www October 10, 2024 10:04 View deployment

vercel bot deployed to Preview – docs-v2 October 10, 2024 10:05 View deployment

joaquim-verges approved these changes Oct 13, 2024

View reviewed changes

kien-ngo force-pushed the kien/erc1155-tests branch from b55a5e5 to 50e359d Compare October 13, 2024 23:30

vercel bot deployed to Preview – wallet-ui October 13, 2024 23:33 View deployment

vercel bot deployed to Preview – thirdweb_playground October 13, 2024 23:33 View deployment

vercel bot deployed to Preview – thirdweb-www October 13, 2024 23:40 View deployment

graphite-app bot merged commit 50e359d into main Oct 13, 2024
30 of 31 checks passed

graphite-app bot deleted the kien/erc1155-tests branch October 13, 2024 23:40

vercel bot deployed to Production – wallet-ui October 13, 2024 23:42 View deployment

vercel bot deployed to Preview – docs-v2 October 13, 2024 23:42 View deployment

vercel bot deployed to Production – docs-v2 October 13, 2024 23:42 View deployment

vercel bot deployed to Production – thirdweb_playground October 13, 2024 23:43 View deployment

vercel bot deployed to Production – thirdweb-www October 13, 2024 23:49 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Improve ERC1155 test coverage #4985

[SDK] Improve ERC1155 test coverage #4985

Uh oh!

kien-ngo commented Oct 10, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 10, 2024

Uh oh!

github-actions bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 10, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 13, 2024 •

edited by kien-ngo

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Improve ERC1155 test coverage #4985

[SDK] Improve ERC1155 test coverage #4985

Uh oh!

Conversation

kien-ngo commented Oct 10, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

github-actions bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 13, 2024 • edited by kien-ngo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Oct 10, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 10, 2024 •

edited

Loading

vercel bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

codecov bot commented Oct 10, 2024 •

edited

Loading

graphite-app bot commented Oct 13, 2024 •

edited by kien-ngo

Loading